feat: dataset update accepts binary value #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1339,6 +1339,26 @@ def test_update_dataset_all_types(tmp_path: Path): | |||
| assert dataset.to_table() == expected | |||
|
|
|||
|
|
|||
| def test_update_with_binary_field(tmp_path: Path): | |||
There was a problem hiding this comment.
nit: can we have a rust test as well?
chebbyChefNEQ
approved these changes
Jul 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2579 +/- ##
==========================================
- Coverage 80.10% 80.10% -0.01%
==========================================
Files 211 211
Lines 61038 61075 +37
Branches 61038 61075 +37
==========================================
+ Hits 48894 48922 +28
+ Misses 9219 9216 -3
- Partials 2925 2937 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wjones127
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.